Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test tsv #3611

Draft
wants to merge 99 commits into
base: main
Choose a base branch
from
Draft

test tsv #3611

wants to merge 99 commits into from

Conversation

wanlwanl
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@mikeharder
WIP: Implement TSV as ESLint Rules
6bb00d3
@mikeharder
Convert to TS (but still cjs)
2b9965f
@mikeharder
Convert to mjs
1ae2452
@mikeharder
Add contoso test
57655ba
@mikeharder
Add rule top-level-folder-lowercase
0615363
@mikeharder
build before test
6e44905
@mikeharder
Rename rule to align with eslint conventions
ae8a8a5
@mikeharder
Rename rule
79256c4
@mikeharder
Improve test
85db158
@mikeharder
Remove sample rule
4973878
@mikeharder
Move e2e tests to separate folder
89006ec
@mikeharder
Add comment
0fe7173
@mikeharder
Add manual unit test
da8c9aa
@mikeharder
Convert test to vitest
abf58cc
@mikeharder
Remove unnecessary async
043d24e
@mikeharder
Rename rule and improve error message
6184c64
@mikeharder
Test eslint disablement comment
b03b666
@mikeharder
Add tests for disabled rule
9c09894
@mikeharder
Include recommended config
a0d0fef
@mikeharder
Move rules to subfolder
0de1b3e
@mikeharder
Cleanup ts-ignore
2208b20
@mikeharder
Remove comment
5b3571f
@mikeharder
WIP: Add Npm.prefix() helper method and tests
cc6d19c
@mikeharder
Use memfs to test fs code
659ed1e
@mikeharder
Add failing tests
a097482
@mikeharder
Implement prefix()
1afea81
@mikeharder
Add more bulk test commands
67ddba4
@mikeharder
Add test workflow
0c239f5
@mikeharder
Downgrade rimraf to v5 for node18 compat
6903a12
@mikeharder
Add code coverage
8978c86
wanlwanl and others added 17 commits January 24, 2025 00:59
@wanlwanl
fix
81508d0
@wanlwanl
Merge branch 'wanl/add-tsp-config-rule' into wanl/adapt-new-rules-to-…
740c3c5 
…old-rules
@wanlwanl
add simple test
73a8562
@wanlwanl
update java rule
f84257b
@wanlwanl
Merge branch 'wanl/add-tsp-config-rule' into wanl/adapt-new-rules-to-…
00ecf30 
…old-rules
@wanlwanl
update test
4d2c8f3
@wanlwanl
add new rules
db989a6
@wanlwanl
remove files
2ba3d59
@JackTn
remove net-track2
317a827
@wanlwanl
fix lint error
9f84497
@wanlwanl
Merge branch 'wanl/add-tsp-config-rule' into wanl/adapt-new-rules-to-…
de66d5d 
…old-rules
@wanlwanl
update lock file
4d1359c
@JackTn
Merge pull request #3597 from test-repo-billy/jacktn/net-track2-migrate
a327b82 
remove net-track2 config
@wanlwanl
delete flavor rule
4e7e4ee
@wanlwanl
Merge branch 'wanl/add-tsp-config-rule' into wanl/adapt-new-rules-to-…
9a5ce80 
…old-rules
@wanlwanl
Merge pull request #3598 from wanlwanl/wanl/adapt-new-rules-to-old-rules
e1764dc 
[TSV] adapt new rules to old rules
@wanlwanl
test tsv
d79b1bc
@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jan 24, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Python (label: BreakingChange-Python-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app-test openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jan 24, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Python azure-mgmt-chaos https://apiviewstagingtest.com/Assemblies/Review/8c5ab16883294a9fb8bfafb0d6337809?revisionId=99420c6b60e4466fa939bafc97abcf11

@azure-sdk azure-sdk mentioned this pull request Jan 24, 2025
Closed
@azure-sdk azure-sdk mentioned this pull request Jan 24, 2025
Closed
@wanlwanl wanlwanl mentioned this pull request Jan 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard will be requested when the pull request is marked ready for review weshaggard is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder will be requested when the pull request is marked ready for review mikeharder is a code owner

@benbp benbp Awaiting requested review from benbp benbp will be requested when the pull request is marked ready for review benbp is a code owner

Assignees
No one assigned
Labels
BreakingChange-Python-Sdk PipelineBotTrigger TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wanlwanl @azure-sdk @AzureRestAPISpecReview @mikeharder @JackTn