Slack: Handle a failure without a failure message

The message attribute of `<failure>` is optional and some tools print the message in the textContent. We shouldn't output `undefined` if it's not present. See test-results-reporter/parser#73 for the root issue
test-results-reporter · Jul 10, 2024 · c01b416 · c01b416
1 parent a826f53
commit c01b416
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/targets/slack.js b/src/targets/slack.js
@@ -129,7 +129,11 @@ function getFailureDetails(suite) {
   for (let i = 0; i < cases.length; i++) {
     const test_case = cases[i];
     if (test_case.status === 'FAIL') {
-      text += `*Test*: ${test_case.name}\n*Error*: ${truncate(test_case.failure, 150)}\n\n`;
+      text += `*Test*: ${test_case.name}\n`;
+      if (test_case.failure) {
+        text += `*Error*: ${truncate(test_case.failure, 150)}\n`;
+      }
+      text += '\n';
     }
   }
   return {