Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing function to purge orphaned containers if they are not disposed #126

Closed
HofmeisterAn opened this issue Aug 12, 2019 · 0 comments
Closed

Add missing function to purge orphaned containers if they are not disposed #126

HofmeisterAn opened this issue Aug 12, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@HofmeisterAn
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In certain circumstances containers remain when tests are aborted or fail with an error.

Describe the solution you'd like
It seems like AppDomain.CurrentDomain.ProcessExit and Console.CancelKeyPress is not working properly (at least on macOS) e. g. STRG + C does not exit the application gracefully. Any other way? See also: dotnet/coreclr#8565.

Describe alternatives you've considered
We can probably use Microsoft.Extensions.Hosting, however, it seems like not working reliable on macOS. IHostedService.StopAsync gets "skipped".

Additional context
n/a
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Aug 12, 2019
@HofmeisterAn HofmeisterAn added this to the 0.0.9 milestone Aug 12, 2019
@HofmeisterAn HofmeisterAn changed the title Purge orphaned containers if they are not disposed automatically Add missing function to purge orphaned containers if they are not disposed Aug 17, 2019
@HofmeisterAn HofmeisterAn modified the milestones: 0.0.9, 1.0.0 Aug 17, 2019
HofmeisterAn added a commit that referenced this issue Oct 4, 2019
@HofmeisterAn
[#126] #IMPLEMENT 'assemblyName: DotNet.Testcontainers; function: Con…
c1141d3 
…tainerRegistry'

{Purge orphaned containers when the default application domain's parent process exits.}
HofmeisterAn added a commit that referenced this issue Oct 4, 2019
@HofmeisterAn
[#126] #IMPLEMENT 'assemblyName: DotNet.Testcontainers; function: Con…
d704c8d 
…tainerRegistry'

{Purge orphaned containers when the default application domain's parent process exits.}
HofmeisterAn added a commit that referenced this issue Oct 4, 2019
@HofmeisterAn
[#126] #IMPLEMENT 'assemblyName: DotNet.Testcontainers; function: Con…
e5fd0cb 
…tainerRegistry'

{Purge orphaned containers when the default application domain's parent process exits.}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@HofmeisterAn