Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageFromDockerfileBuilder does not have possibility to specify docker file name #180

Closed
paulvanbladel opened this issue Jan 8, 2020 · 5 comments
Closed

ImageFromDockerfileBuilder does not have possibility to specify docker file name #180

paulvanbladel opened this issue Jan 8, 2020 · 5 comments
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@paulvanbladel
Copy link

Nice project !
Would be cool to be able to specify name of dockerfile. Now you can only specify the directory.
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Jan 8, 2020
@HofmeisterAn HofmeisterAn added this to the 1.1.0 milestone Jan 8, 2020
@HofmeisterAn
Copy link
Collaborator

Do you talk about the ImageFromDockerfileBuilder? This should be pretty simple, we just need to extend the interfaces IImageFromDockerfileBuilder and IImageFromDockerfileConfiguration and pass the Dockerfile name to: https://github.com/HofmeisterAn/dotnet-testcontainers/blob/a379b7817a40565283ce268de934f8f88174c858/src/DotNet.Testcontainers/Clients/DockerImageOperations.cs#L87

I can probably take a look at it this weekend. Or would you like to create a PR?

@HofmeisterAn HofmeisterAn mentioned this issue Jan 8, 2020
Closed
HofmeisterAn added a commit that referenced this issue Jan 10, 2020
@HofmeisterAn
[#180] #EXTEND 'assemblyName: DotNet.Testcontainers; function: IImage…
22bd094 
…FromDockerfileBuilder'

{Add WithDockerfile to IImageFromDockerfileBuilder.}
HofmeisterAn added a commit that referenced this issue Jan 10, 2020
@HofmeisterAn
[#180] #EXTEND 'assemblyName: DotNet.Testcontainers; function: IImage…
e2c6c18 
…FromDockerfileBuilder'

{Add WithDockerfile to IImageFromDockerfileBuilder.}
@HofmeisterAn
Copy link
Collaborator

PR #182.

@paulvanbladel
Copy link
Author

Thanks a lot Andrė.

@paulvanbladel
Copy link
Author

@HofmeisterAn .
Is this also on nuget André?
Cheers.

@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented Jan 11, 2020 •
edited
Loading

@paulvanbladel Yes, each commit on develop publishes a new prerelease in your case 1.1.0-beta.20200110.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@paulvanbladel @HofmeisterAn