Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithStartupCallback may result in a deadlock #356

Closed
HofmeisterAn opened this issue Jan 22, 2021 · 1 comment
Closed

WithStartupCallback may result in a deadlock #356

HofmeisterAn opened this issue Jan 22, 2021 · 1 comment
Labels
bug Something isn't working
Milestone
1.5.0

Comments

@HofmeisterAn
Copy link
Collaborator

Describe the bug
If ITestcontainersBuilder<out TDockerContainer>.WithStartupCallback calls a IDockerContainer method that enters the semaphoreSlim in TestcontainersContainer, the container start will run into a deadlock.

To Reproduce
Steps to reproduce the behavior:

.WithStartupCallback((container, ct) => container.GetExitCode(ct))

Expected behavior
No deadlock.

Screenshots
-

Desktop (please complete the following information):

  • Version 1.5.0-beta.20210122.3

Additional context
-
@HofmeisterAn HofmeisterAn added the bug Something isn't working label Jan 22, 2021
@HofmeisterAn HofmeisterAn mentioned this issue Jan 22, 2021
Closed
HofmeisterAn added a commit that referenced this issue Jan 27, 2021
@HofmeisterAn
[#356] #BUGFIX 'assemblyName: DotNet.Testcontainers; function: IDocke…
f612beb 
…rContainer'

{Do not expose IDockerContainer to WithStartupCallback.}
HofmeisterAn added a commit that referenced this issue Jan 27, 2021
@HofmeisterAn
[#356] #BUGFIX 'assemblyName: DotNet.Testcontainers; function: IDocke…
765e8d7 
…rContainer'

{Do not expose IDockerContainer to WithStartupCallback.}
HofmeisterAn added a commit that referenced this issue Jan 28, 2021
@HofmeisterAn
[#356] #BUGFIX 'assemblyName: DotNet.Testcontainers; function: IDocke…
a792627 
…rContainer'

{Do not expose IDockerContainer to WithStartupCallback.}
@HofmeisterAn HofmeisterAn added this to the 1.5.0 milestone Jan 28, 2021
@HofmeisterAn
Copy link
Collaborator Author

#358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@HofmeisterAn