Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend WithDockerEndpoint method with Docker.DotNet.Credentials parameter #456

Closed
MarcinSzyszka opened this issue May 14, 2022 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@MarcinSzyszka
Copy link

Is your feature request related to a problem? Please describe.
I want to connect to docker with TLS and I want to pass credentials object prepared by my own - exactly the same way as it is done in Docker.DotNet library used in dotnet-testcontainers library

Describe the solution you'd like
Allow to pass Docker.DotNet.Credentials object as parameter

Describe alternatives you've considered
There is no chance to connect to docker with TLS now

Additional context
It's simple change by it would allow user to connect to secured docker api (not only with TLS)
Leave credentials configuration to user exactly as it is done in Docker.DotNet library

I will create PR with changes after submiting this issue to follow contributing rules

MarcinSzyszka added a commit to MarcinSzyszka/dotnet-testcontainers that referenced this issue May 14, 2022
…nction: WithDockerEndpoint ' {Extended method with Docker.DotNet.Credentials parameter and made required changes to related code to pass credentials to Docker.DotNet.DockerClientConfiguration ctor }
MarcinSzyszka added a commit to MarcinSzyszka/dotnet-testcontainers that referenced this issue May 14, 2022
…ts; class: TestcontainersAccessInformationTest' {Fixed tests after changes added in previous commit}
@HofmeisterAn
Copy link
Collaborator

I'll close this in favor of #370. There is already an ongoing discussion. Please notice, that the library does not expose models from Docker.DotNet. Here is a short summary about the tasks.

@HofmeisterAn HofmeisterAn added duplicate This issue or pull request already exists enhancement New feature or request labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants