Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize docker registry for ryuk image when using default resource reaper #483

Closed
harrhp opened this issue Jun 17, 2022 · 3 comments
Closed

Customize docker registry for ryuk image when using default resource reaper #483

harrhp opened this issue Jun 17, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone
2.1.0

Comments

@harrhp
Copy link

harrhp commented Jun 17, 2022

Is your feature request related to a problem? Please describe.
When default session of resource reaper is started it uses image that points to public registry, it is a problem when running tests in CI without internet access.

Describe the solution you'd like
Expose property in TestcontainersSettings that allows to specify registry (and tag ?) for ryuk image

Describe alternatives you've considered
It's probably possible to disable default resource reaper and manage session manually but it's more code

Additional context
Add any other context or screenshots about the feature request here.
@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented Jun 18, 2022 •
edited
Loading

OC, let's add this. What about IDockerImage TestcontainersSettings.ResourceReaperImage? We could achieve the same thing with HubImageNamePrefix, but the Ryuk image we're using right now is not on Docker Hub.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Jun 18, 2022
@HofmeisterAn HofmeisterAn added this to the 1.7.0 milestone Jun 18, 2022
@harrhp
Copy link
Author

harrhp commented Jun 20, 2022

IDockerImage TestcontainersSettings.ResourceReaperImage is good, it would allow to change image name also (potentialy for another existing image or custom built image)

@HofmeisterAn HofmeisterAn modified the milestones: 2.0.0, 2.1.0 Jun 21, 2022
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 21, 2022
@VlastimilKaluzaYsoft
feat(testcontainers#483): Added TestcontainersSettings.ResourceReaper…
bcb237f 
…Image property to customize Resource Reaper image
@HofmeisterAn HofmeisterAn mentioned this issue Jun 22, 2022
Closed
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 22, 2022
@VlastimilKaluzaYsoft @vlaskal
feat(testcontainers#483): Added TestcontainersSettings.ResourceReaper…
c8c6cba 
…Image property to customize Resource Reaper image
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 23, 2022
@VlastimilKaluzaYsoft @vlaskal
feat(testcontainers#483): Added TestcontainersSettings.ResourceReaper…
c117407 
…Image property to customize Resource Reaper image
@vlaskal vlaskal mentioned this issue Jun 24, 2022
Closed
HofmeisterAn pushed a commit that referenced this issue Jun 24, 2022
@VlastimilKaluzaYsoft @HofmeisterAn
feat(#483): Add TestcontainersSettings.ResourceReaperImage property
3c129ed
@HofmeisterAn
Copy link
Collaborator

Published in 2.1.0-beta.2561986470.

@HofmeisterAn HofmeisterAn removed the RFD label Jul 3, 2022
@Zubastick Zubastick mentioned this issue Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@HofmeisterAn @harrhp