Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Microsoft SQL Server example #1008

Merged
merged 2 commits into from
Oct 3, 2023
Merged

docs: Add Microsoft SQL Server example #1008

merged 2 commits into from
Oct 3, 2023

Conversation

khalidabuhakmeh
Copy link
Contributor

What does this PR do?

This adds a Microsoft SQL Server example to the documentation page.

Why is it important?

For documentation completeness.

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 19c2074
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/651bc2be6567600008293855
😎 Deploy Preview https://deploy-preview-1008--testcontainers-dotnet.netlify.app/modules/microsoft-sql-server
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HofmeisterAn
HofmeisterAn previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🍂. I applied some minor changes to keep both examples more consistent.

docs/modules/microsoft-sql-server.md Outdated Show resolved Hide resolved
@HofmeisterAn HofmeisterAn added the documentation Docs, docs, docs. label Oct 3, 2023
@HofmeisterAn HofmeisterAn changed the title Add Microsoft SQL Server documentation docs: Add Microsoft SQL Server example Oct 3, 2023
@HofmeisterAn HofmeisterAn merged commit c7d8cfd into testcontainers:develop Oct 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees
No one assigned
Labels
documentation Docs, docs, docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalidabuhakmeh @HofmeisterAn