-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Azurite): Add in-memory support #1063
feat(Azurite): Add in-memory support #1063
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍 I have some minor change requests, but overall, it looks really good. I will be happy to merge it once the requested changes are addressed.
…ners-dotnet into Xzelsius-inmemory-persistence
I made slight changes to the tests. Instead of creating a new class, we can reuse the previous test class. Does the PR look good to you? What do you think? I am ready to merge it. Thanks for your contribution. |
@HofmeisterAn That's actually a way better solution than what I did with the test :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the issue and PR 🙏.
What does this PR do?
Updates the default Azurite image to v3.28.0
Additionally, adds support for the new in-memory persistence flag
--inMemoryPersistence
The new in-memory persistence is opt-in and needs to be enabled using
.WithInMemoryPersistence()
on the Azurite builder.As default, the memory limit is 50% of the available Docker host RAM, but it can be overridden by specifying it in the
.WithInMemoryPersistence(<memory-limit-in-mb>)
call.Why is it important?
Using in-memory persistence may have a positive effect on overall performance of Azurite during tests, as it does not need to store stuff on disk.
Related issues