feat: Add CockroachDB module #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Ready for review. Thanks @HofmeisterAn for some extra help. |
|
FYI: I have not forgotten to review the PR. I will do it at the latest when I am back from the holidays. |
|
Ready for review again; I've resolved the conflicts due to the new changes in the develop branch. |
|
@rafaumlemos, sorry for the delay. I am very busy right now. I just had the time to review your pull request. The PR looks good. Thanks for the contribution 🥳! I will merge the PR later. |
HofmeisterAn
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces Testcontainers.CockroachDB to the project
Why is it important?
It's important to support CockroachDB
Related issues
How to test this PR
I implemented the same test logic used by PostgreSQL as a reference
Follow-ups
The implementation closely resembles that of PostgreSQL