Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use the pg_isready command to assess whether PostgreSQL is ready or not #1111

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Feb 10, 2024

This strategy aligns with the MySQL and MariaDb wait strategies.

Also, logs have changed over time and the current strategy doesn't work with older PostgreSQL Docker images (for example v9.6) which does not produce the same logs as recent versions of the PostgreSQL docker image.

This strategy aligns with the MySQL and MariaDb wait strategies.

Also, logs have changed over time and the current strategy doesn't work with older PostgreSQL Docker images (for example v9.6) which does not produce the same logs as recent versions of the PostgreSQL docker image.
Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit e2b0901
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65c7fa61493e3a0008c9d11e
😎 Deploy Preview https://deploy-preview-1111--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Feb 11, 2024
@HofmeisterAn HofmeisterAn changed the title Use the pg_isready command to asses whether PostgreSQL is ready or not chore: Use the pg_isready command to assess whether PostgreSQL is ready or not Feb 11, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HofmeisterAn HofmeisterAn merged commit f9afd0c into testcontainers:develop Feb 11, 2024
11 checks passed
@0xced 0xced deleted the pg_isready branch February 11, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants