Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prevent ReusableResourceTest from leaking resources #1164

Merged

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Apr 26, 2024

Fixes #1157

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 2945036
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/662cfe66bcb9cb000812419f
😎 Deploy Preview https://deploy-preview-1164--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0xced 0xced force-pushed the feature/CleanupReusableResourceTest branch from 78f147f to c009b64 Compare April 27, 2024 06:25
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea 💡. I think we can slightly improve setting the SessionId. Happy to merge it afterward.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Apr 27, 2024
0xced and others added 2 commits April 27, 2024 14:48
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
@HofmeisterAn HofmeisterAn changed the title chore: Cleanup resources in ReusableResourceTest chore: Prevent ReusableResourceTest from leaking resources Apr 27, 2024
@HofmeisterAn HofmeisterAn merged commit d5552d0 into testcontainers:develop Apr 27, 2024
11 checks passed
@0xced 0xced deleted the feature/CleanupReusableResourceTest branch April 27, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ReusableResourceTest leaks docker resources
2 participants