fix: Do not run reusable resource tests in parallel #1267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses a flaky unit test I noticed some time ago. The reusable resource tests (reuse feature) have been flaky, and today I discovered that they interfere with the port forwarding tests. When the port forwarding container is running, Testcontainers automatically injects the necessary extra hosts into the builder configuration using
WithPortForwarding()
internally. Depending on when the test framework starts the port forwarding container, these extra hosts can cause flakiness. This happens because the reuse hash may change during iterating and creating the container resource(s), resulting in two containers with the same label running instead of one.I noticed the issue by looking into the actual container configurations and their hashes (see the JSON node
ExtraHosts
):In addition to fixing this issue, the PR aligns two similar tests, now includes the stack trace of an exception in the log message and bumps the test dependencies to their latest version.
Why is it important?
This PR improves the stability and resilience of the CI pipeline and tests.
Related issues
-