chore: Run each test project on a separate runner #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofmeisterAn
added
the
chore
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
deleted the
feature/run-test-projects-on-multiple-runners
branch
0xced
added a commit
to 0xced/testcontainers-dotnet
that referenced
this pull request
Nov 23, 2024
Because it's too easy to forget to add a line in the cicd.yml after creating a new module. This is a safety measure after the introduction of running each test project on a separate runner in testcontainers#1295.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The pull request changes how we run our tests by running each test project on a separate runner. Previously, all test projects were run on the same runner, which caused issues due to running out of disk space and subsequently blocked merging new module pull requests. We need to monitor whether this change affects the Testcontainers organization. I am uncertain if creating too many runners might lead to degradation of the entire organization.
Why is it important?
-
Related issues