Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wait until container ports are mapped, removed generated credentials #791

Merged
merged 9 commits into from
Feb 20, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Sets default module credentials.

Why is it important?

If we generate credentials, we will be unable to detect whether a resource is reusable or not.

Related issues

@HofmeisterAn HofmeisterAn added bug Something isn't working enhancement New feature or request labels Feb 17, 2023
@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 30ba832
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63f366bb44b69900083756a0
😎 Deploy Preview https://deploy-preview-791--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn changed the title Feature/remove generated credentials fix: Wait until container ports are mapped, removed generated credentials Feb 20, 2023
@HofmeisterAn HofmeisterAn merged commit 7b6e0ae into develop Feb 20, 2023
@HofmeisterAn HofmeisterAn deleted the feature/remove-generated-credentials branch February 20, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants