Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JanusGraph module #837

Conversation

rngcntr
Copy link
Contributor

@rngcntr rngcntr commented Mar 17, 2023

What does this PR do?

This PR adds a module for the Graph Database JanusGraph.
For the moment, only the most basic configuration of JanusGraph is supported.
Support for other backends can be added later. However, this simple configuration should be sufficient to for the majority of use cases.

Why is it important?

JanusGraph is used by a variety of companies to build scalable graph database solutions. By providing a Testcontainers module, we lower the entry barrier for new developers to write meaningful tests.

Follow-ups

  • Wait for final 1.0.0 Release of JanusGraph
  • Support different storage backends

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 85496da
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6554a2d0dd3aac000818c9b9
😎 Deploy Preview https://deploy-preview-837--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rngcntr rngcntr marked this pull request as draft March 17, 2023 08:27
@rngcntr
Copy link
Contributor Author

rngcntr commented Mar 17, 2023

For some reason, the container is unable to start properly in the CI. I'll have to push a few commits to add some temporary code for debugging.

@rngcntr rngcntr force-pushed the introduce-janusgraph-module branch 2 times, most recently from 49568a1 to 9b0f575 Compare March 17, 2023 10:36
@rngcntr rngcntr marked this pull request as ready for review March 22, 2023 06:58
@rngcntr rngcntr force-pushed the introduce-janusgraph-module branch from 9b0f575 to 2174524 Compare March 22, 2023 07:02
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for submitting this pull request! I've reviewed your changes and overall, everything looks great. However, I have a small change request regarding the 3rd party client dependencies.

src/Testcontainers.JanusGraph/JanusGraphBuilder.cs Outdated Show resolved Hide resolved
@rngcntr rngcntr force-pushed the introduce-janusgraph-module branch from 2174524 to bb6bb7e Compare March 22, 2023 13:03
HofmeisterAn
HofmeisterAn previously approved these changes Mar 23, 2023
@HofmeisterAn HofmeisterAn changed the title Introduce JanusGraph module feat: Add JanusGraph module Mar 23, 2023
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Mar 23, 2023
@rngcntr rngcntr force-pushed the introduce-janusgraph-module branch 3 times, most recently from d22b09c to 348229f Compare August 22, 2023 06:21
@rngcntr rngcntr force-pushed the introduce-janusgraph-module branch from 348229f to 2fa056a Compare November 15, 2023 08:48
@rngcntr rngcntr force-pushed the introduce-janusgraph-module branch from 2fa056a to 85496da Compare November 15, 2023 10:51
@HofmeisterAn HofmeisterAn merged commit 7b6a862 into testcontainers:develop Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants