Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Keycloak module #880

Merged
merged 8 commits into from
May 12, 2023
Merged

feat: Add Keycloak module #880

merged 8 commits into from
May 12, 2023

Conversation

VMelnalksnis
Copy link
Contributor

What does this PR do?

Introduce Keycloak module.

Why is it important?

Allows to run integration tests with OAuth/OIDC auth.

Related issues

Closes #879

@netlify
Copy link

netlify bot commented May 4, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 859888b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/645df9f9c6224200089dcbe7
😎 Deploy Preview https://deploy-preview-880--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

HofmeisterAn
HofmeisterAn reviewed May 8, 2023
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. The Keycloak module configuration looks quite good. I just have a minor question or suggestion to improve it. Other than that, great work! Thank you 🥳.

src/Testcontainers.Keycloak/KeycloakBuilder.cs Outdated Show resolved Hide resolved
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label May 8, 2023
@HofmeisterAn HofmeisterAn changed the title Add Keycloak module feat: Add Keycloak module May 8, 2023
HofmeisterAn
HofmeisterAn reviewed May 12, 2023
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. Anything left? Ready for review?

@VMelnalksnis
Copy link
Contributor Author

This should be it, unless I need to rebase the latest changes again.

@VMelnalksnis VMelnalksnis marked this pull request as ready for review May 12, 2023 06:54
@HofmeisterAn
Copy link
Collaborator

This should be it, unless I need to rebase the latest changes again.

👍 No, you don't. I'll merge it later. Thanks already.

HofmeisterAn
HofmeisterAn approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙌.

@HofmeisterAn HofmeisterAn merged commit 36ded55 into testcontainers:develop May 12, 2023
@VMelnalksnis VMelnalksnis deleted the keycloak branch May 12, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Keycloak module
2 participants
@VMelnalksnis @HofmeisterAn