feat: Add TC host strategy #885
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
force-pushed
the
feature/add-testcontainers-host-strategy
branch
from
06efa6b to
551ef20
Compare
| /// <inheritdoc /> | ||
| public string GetDockerHostOverride() | ||
| { | ||
| return _customConfiguration.GetDockerHostOverride(); |
There was a problem hiding this comment.
I see _customConfiguration implements PropertiesFileConfiguration, does this also take into account environment variable configurations?
There was a problem hiding this comment.
No, it does not. It purely relies on the properties file. I asked myself the same question, if it should. Until now, TC for .NET use either of both ways to configure TC.
There was a problem hiding this comment.
I don't fully understand the question @cristianrgreco.
We effectively want TestcontainersHostConfiguration to only be configured through the testcontainers.host property in the property file, right? And this implementation follows this and hence is correct I assume.
There was a problem hiding this comment.
Discussed internally, but added here for transparency:
Since this is effectively the integration with Testcontainer Cloud, it's clearer if we rename the strategy accordingly.
| /// <inheritdoc /> | ||
| public string GetDockerHostOverride() | ||
| { | ||
| return _customConfiguration.GetDockerHostOverride(); |
There was a problem hiding this comment.
I don't fully understand the question @cristianrgreco.
We effectively want TestcontainersHostConfiguration to only be configured through the testcontainers.host property in the property file, right? And this implementation follows this and hence is correct I assume.
src/Testcontainers/Builders/TestcontainersCloudEndpointAuthenticationProvider.cs
Show resolved
Hide resolved
src/Testcontainers/Builders/TestcontainersCloudEndpointAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Builders/TestcontainersCloudEndpointAuthenticationProvider.cs
Show resolved
Hide resolved
…icationProvider.cs Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
What does this PR do?
Adds a new strategy for auto-discovering container runtimes.
Why is it important?
?
Related issues
-