-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Azure Data Explorer Kusto emulator module #963
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR and contribution. I have some minor suggestions. Maybe we can use the HTTP wait strategy implementation instead of the custom wait strategy (dunno if we need the JSON payload). Happy to merge the PR afterward.
Suggestion of @HofmeisterAn Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
…y) of the HTTP request
Thanks for the fast feedback 👍 |
I have planned a new release, end of this week. I can wait until this PR is ready and do it afterward. |
src/Testcontainers/Configurations/WaitStrategies/HttpWaitStrategy.cs
Outdated
Show resolved
Hide resolved
src/Testcontainers/Configurations/WaitStrategies/HttpWaitStrategy.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! PR looks good.
What does this PR do?
Introduces a Azure Data Explorer Kusto emulator module.
The documentation about it can be found here: https://learn.microsoft.com/en-us/azure/data-explorer/kusto-emulator-install
Why is it important?
Simplifies the setup of a Kusto testcontainer with all necessary parameters and a robust Wait strategy.
Having a specific KustoContainer also enables custom extension methods, strong typing, ...