Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add global Testcontainers header #967

Merged

Conversation

leocross
Copy link
Contributor

@leocross leocross commented Aug 8, 2023

What does this PR do?

Adds a global navigation to the documentation that mirrors the navigation on https://testcontainers.com/

Why is it important?

Testcontainers is a cross-language project and many resources like the getting started article, guides and the modules library that are not specific to a language implementation are hosted one testcontainers.com. Adding a global header with consistent navigation between the project site and the language documentation will help new and existing users discover these resources.

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit a655514
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64e3b92c453888000899f749
😎 Deploy Preview https://deploy-preview-967--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn changed the title Add global testcontainers header to docs docs: Add global Testcontainers header Aug 8, 2023
@HofmeisterAn HofmeisterAn added the documentation Docs, docs, docs. label Aug 8, 2023
HofmeisterAn
HofmeisterAn previously approved these changes Aug 8, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Leo! Looks great as always ✌️. I saw Manu left some comments in the Go PR. Should we wait until they are addressed to have a consistent implementation across the languages?

@mdelapenya
Copy link
Member

I saw Manu left some comments in the Go PR

You mean this? testcontainers/testcontainers-go#1308 (comment)

I went ahead and committed testcontainers/testcontainers-go@2f9ea0c

docs/index.md Outdated Show resolved Hide resolved
@HofmeisterAn HofmeisterAn merged commit 99ff005 into testcontainers:develop Aug 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants