-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add InfluxDb module #975
feat: Add InfluxDb module #975
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request. The majority of it looks good. I've removed the BOMs and applied some common code styles. I've also included two minor suggestions. This is a great first Testcontainers for .NET contribution 👍. Thanks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks!
What does this PR do?
This PR adds support for starting [InfluxDb] containers.
Why is it important?
This is required to write tests that target a InfluxDb database.
Related issues
How to test this PR
cd tests/Testcontainers.InfluxDb.Tests
dotnet test