Canned mysql (2nd attempt) #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference testcontainers#19 I bootstrapped a mysql canned container. ``` ctx := context.Background() c, err := MySQLContainer(ctx, MySQLContainerRequest{ RootPassword: "root", Database: "hello", }) if err != nil { t.Fatal(err.Error()) } defer c.Container.Terminate(ctx) sqlC, err := c.GetDriver("root", "root", "hello") if err != nil { t.Fatal(err.Error()) } _, err = sqlC.ExecContext(ctx, "CREATE TABLE example ( id integer, data varchar(32) )") if err != nil { t.Fatal(err.Error()) } ``` Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
Closed
kindratmakc
approved these changes
Feb 28, 2020
|
Hello! At this point in time, I think we are not ready to onboard canned/modules as part of the main repository. Thanks a lot |
|
We started this PR, which could be the seed for modules: #618 It creates examples to be consumed by the website, but turning them into modules would be a matter of adjusting the templates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao @gianarb !
I initially wanted to target your
feature/canned-mysqlbranch but I ended up having to rebase to master...I tried to align it based on the comments in #59 #98 #102 #105