Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support detecting if k3s module is running from inside a Docker container #1289

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: support detecting if k3s module is running from inside a Docker container #1289

merged 1 commit into from
Jun 15, 2023

Commits on Jun 15, 2023

  1. fix: fix k3s module when running from inside a Docker container 

    The k3s module previously didn't work properly inside of a Docker
container; the caller would connect to its HTTPS server via the Docker
network gateway, which wasn't included in the list of SANS from the TLS
certificate exposed by the k3s container.

This change determines what the DaemonHost address is prior to creating
the container request, and then injects that address as one of the TLS
SANs.

When not running in a Docker container, the k3s module continues to
function as it did before, as the DaemonHost address in that scenario is
"localhost".
    @rfratto
    rfratto committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4e2d74f View commit details
    Browse the repository at this point in the history