Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove gotestsum to reduce the number of transitive dependencies #1303

Merged
merged 6 commits into from
Jun 23, 2023

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Jun 23, 2023

What does this PR do?

This PR removes the dependency with gotestsum, as it comes with a bunch of transitive dependencies

For that reason we are updating the GH pipelines to install gotestsum at the pipeline.

We are also removing all tools.go files, as they are not used anymore.

Why is it important?

Reduce the number of transitive dependencies, that are only used for working while working on the project.

@mdelapenya mdelapenya requested a review from a team as a code owner June 23, 2023 13:16
@mdelapenya mdelapenya added the dependencies Dependencies or external services label Jun 23, 2023
@mdelapenya mdelapenya self-assigned this Jun 23, 2023
@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 471e6ef
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6495babd92160200083876a0
😎 Deploy Preview https://deploy-preview-1303--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya mdelapenya marked this pull request as draft June 23, 2023 14:08
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya marked this pull request as ready for review June 23, 2023 15:38
@mdelapenya mdelapenya merged commit f5a4a54 into testcontainers:main Jun 23, 2023
@mdelapenya mdelapenya deleted the remove-gotestsum branch August 1, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant