Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run dependabot on sundays #1446

Merged
merged 7 commits into from
Aug 7, 2023

Conversation

mdelapenya
Copy link
Member

What does this PR do?

This PR does:

  • updates the dependabot file to run only monthly on Sundays
  • updates the test assertions for dependabot generation
  • removes an outdated if clause when generating modules
  • updates the code generation to use the os package instead of deprecared APIs in ioutil
  • autogenerates dependabot code properly, moving github-actions and pip to the first two elements

Why is it important?

Idempotency in the code generation, and more predictability on when the dependabot updates will be called, using the weekend window to avoid affecting the rest of the teams.

@mdelapenya mdelapenya requested a review from a team as a code owner August 7, 2023 11:56
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 7, 2023
@mdelapenya mdelapenya self-assigned this Aug 7, 2023
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 0aea7e9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64d0e5219366a8000803c304
😎 Deploy Preview https://deploy-preview-1446--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya added dependencies Dependencies or external services and removed chore Changes that do not impact the existing functionality labels Aug 7, 2023
Copy link
Contributor

@cristianrgreco cristianrgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdelapenya! 🙏

@mdelapenya mdelapenya merged commit 56cb52a into testcontainers:main Aug 7, 2023
106 checks passed
@mdelapenya mdelapenya deleted the dependabot-schedule branch August 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants