Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups in dependabot updates #1459

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Support groups in dependabot updates #1459

merged 6 commits into from
Aug 9, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Aug 8, 2023

Support groups in dependabot updates

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d2c4333
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64d3cf99c6330d0008f81263
😎 Deploy Preview https://deploy-preview-1459--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmorel-35 mmorel-35 marked this pull request as ready for review August 9, 2023 04:13
@mmorel-35 mmorel-35 requested a review from a team as a code owner August 9, 2023 04:13
@mdelapenya
Copy link
Member

@mmorel-35 thanks for this! Do you envision adding groups now? I'd like to read more about it and create logical groups (i.e. all the Google Cloud emulators could go together, or identify from previous PRs what deps are present in multiple modules).

Would like to help me in identifying those groups?

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Aug 9, 2023

I don't want to add them necessarily now but in case you would try to add them manually in the dependabot file this would avoid an unexpected deletion when a new example or module is added.

In the first time you could go manually, module by module for common providers for example
"github.com/toto/module1" and "github.com/toto/module2" could be grouped together as "github.com/toto" with pattern "github.com/toto/*"

@mdelapenya
Copy link
Member

in case you would try to add them manually in the dependabot file this would avoid an unexpected deletion when a new example or module is added.

💯

@mdelapenya
Copy link
Member

I think we could start with a group per module, having a wildcard * for all the dependencies in the module. This will create a single PR per module, which is much better than the current situation.

An edge case could be a dependency that is present in multiple modules... but we already live in that world

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

What do you think about this @mdelapenya ?

@@ -39,6 +46,11 @@ func NewUpdate(example Example) Update {
Interval: updateSchedule,
Day: "sunday",
},
Groups: Groups{
"all": Group{
Patterns: []string{"*"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double check that this will generate:

      groups:
        all:
          patterns:
            - "*"

and no:

      groups:
        all:
          patterns:
            - *

🙏

From modules dir:

go run . --name questdb --image "questdb/questdb:latest" --title QuestDB --as-module

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that shall be alright

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this 🤝

@mdelapenya mdelapenya self-assigned this Aug 9, 2023
@mdelapenya mdelapenya added the dependencies Dependencies or external services label Aug 9, 2023
@mdelapenya mdelapenya merged commit 82c79f7 into testcontainers:main Aug 9, 2023
106 checks passed
@mdelapenya
Copy link
Member

Merge, thanks! 👏👏👏

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 10, 2023
* main:
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 10, 2023
* main:
  Add support for MongoDB testing module (testcontainers#1447)
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
  Add default labels when Ryuk is disabled (testcontainers#1339)
  feat: add clickhouse module (testcontainers#1372)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Aug 10, 2023
* main: (29 commits)
  Add support for MongoDB testing module (testcontainers#1447)
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
  Add default labels when Ryuk is disabled (testcontainers#1339)
  feat: add clickhouse module (testcontainers#1372)
  chore: increase timeout for go test and GH action steps (testcontainers#1475)
  chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474)
  chore(deps): bump github.com/aws dependencies in /modules/localstack (testcontainers#1472)
  chore(deps): bump Google emulators dependencies in /examples (testcontainers#1471)
  all: fix goroutine leaks (testcontainers#1358)
  chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1427)
  chore(deps): bump github.com/tidwall/gjson from 1.14.4 to 1.15.0 in /modules/vault (testcontainers#1428)
  chore: add a GH action for release drafter (testcontainers#1470)
  chore(deps): bump mkdocs-material from 3.2.0 to 8.2.7 (testcontainers#1468)
  Add global testcontainers header to docs (testcontainers#1308)
  Simplify dependabot updates sorting (testcontainers#1460)
  feat: use credential helper in docker config, even if auth is empty in .docker/config.json (testcontainers#1079)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1457)
  Revert "chore: run Windows tests on a Linux container (testcontainers#1456)"
  chore: run Windows tests on a Linux container (testcontainers#1456)
  ...
@mmorel-35 mmorel-35 deleted the mmorel-35-08082023 branch August 10, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants