fix: run tests for module generator in all platforms #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
The tests passed on Windows, so I think this is good to go! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new input parameter to the reusable workflow, in order to "run the tests" step. Is true, it will execute the step.
With this approach the caller decides whether the tests are run or not passing true/false in the new
run-testsparameter. In general, they will pass atruevalue, but for the core library, where we want to run the tests only for Linux, we must check that the platform isubuntu-latest, only.Why is it important?
We noticed the value was hardcoded to run the tests only on Ubuntu, directly into the reusable workflow, but there are callers that need to run the tests on Mac and Windows too. For that reason we needed a way to tell the reusable workflow to skip the tests or to run them.
Related issues