-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modulegen: create internal/dependabot #1503
modulegen: create internal/dependabot #1503
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
modulegen/dependabot.go
Outdated
@@ -1,96 +1,20 @@ | |||
package main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd try to move all dependabot code from the main package to the new pkg/dependabot
, so that the main.go file just consumes what the dependabot
package exposes.
On the other hand, let's think if we want to expose a public API for handling dependabot files, using the publicly available pkg/dependabot
package (which could be consumed in the wild), or on the contrary keep it internal (i.e. ./internal/dependabot
).
Before moving on with this PR and #1504 and #1505, let's discuss first about the APIs that we want to create, and the project layout for that. Let's iterate in one single command, and once we are happy with it, let's move to the others. I'm open to have a slack chat/huddle or zoom call for sync if needed
Does it sound good to you?
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only a minor comment regarding a method name, but great job moving code around.
Thanks!
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Waiting for the CI, which will pass ✅
Refactor dependabot code in modulegen