Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulegen: create internal/dependabot #1503

Merged
merged 2 commits into from
Aug 21, 2023
Merged

modulegen: create internal/dependabot #1503

merged 2 commits into from
Aug 21, 2023

Conversation

mmorel-35
Copy link
Contributor

Refactor dependabot code in modulegen

@mmorel-35 mmorel-35 requested a review from a team as a code owner August 15, 2023 07:57
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 760c5dc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64e3360cf5bd3d0008896bfd
😎 Deploy Preview https://deploy-preview-1503--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -1,96 +1,20 @@
package main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try to move all dependabot code from the main package to the new pkg/dependabot, so that the main.go file just consumes what the dependabot package exposes.

On the other hand, let's think if we want to expose a public API for handling dependabot files, using the publicly available pkg/dependabot package (which could be consumed in the wild), or on the contrary keep it internal (i.e. ./internal/dependabot).

Before moving on with this PR and #1504 and #1505, let's discuss first about the APIs that we want to create, and the project layout for that. Let's iterate in one single command, and once we are happy with it, let's move to the others. I'm open to have a slack chat/huddle or zoom call for sync if needed

Does it sound good to you?

@mmorel-35 mmorel-35 changed the title modulegen: create pkg/dependabot modulegen: create internal/dependabot Aug 17, 2023
@mmorel-35 mmorel-35 marked this pull request as draft August 18, 2023 16:17
@mmorel-35 mmorel-35 marked this pull request as ready for review August 19, 2023 10:51
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mdelapenya
mdelapenya previously approved these changes Aug 21, 2023
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a minor comment regarding a method name, but great job moving code around.

Thanks!

modulegen/internal/dependabot/main.go Outdated Show resolved Hide resolved
modulegen/main_test.go Outdated Show resolved Hide resolved
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Waiting for the CI, which will pass ✅

@mdelapenya mdelapenya self-assigned this Aug 21, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 21, 2023
@mdelapenya mdelapenya merged commit 41c24e0 into testcontainers:main Aug 21, 2023
117 checks passed
@mmorel-35 mmorel-35 deleted the modulegen/dependabot branch August 21, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants