Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules/redpanda): support tls #1511

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

abemedia
Copy link
Contributor

@abemedia abemedia commented Aug 17, 2023

What does this PR do?

Adds WithEnableTLS option to enable TLS with a custom certificate and key PEM.

I also tweaked redpanda to clean up any temporary files as it currently leaves behind a bunch of files on every run which are never removed. Happy to move that into a separate PR if you guys feel it conflates this one a little too much.

Why is it important?

This allows testing code which requires TLS connections to Kafka.

Related issues

@abemedia abemedia requested a review from a team as a code owner August 17, 2023 22:30
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 7243299
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64e45b41ea84ea00080ca712
😎 Deploy Preview https://deploy-preview-1511--testcontainers-go.netlify.app/modules/redpanda
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abemedia thanks for this nice improvement! I think it LGTM, although I left a few comments that need to be addressed before merging the PR.

Please let me know your thoughts

modules/redpanda/options.go Outdated Show resolved Hide resolved
modules/redpanda/redpanda_test.go Outdated Show resolved Hide resolved
modules/redpanda/redpanda_test.go Outdated Show resolved Hide resolved
modules/redpanda/redpanda.go Outdated Show resolved Hide resolved
modules/redpanda/redpanda_test.go Show resolved Hide resolved
@mdelapenya
Copy link
Collaborator

Please remember including docs for this new option in the docs site. After that, I think this little one is ready to be merged

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abemedia
Copy link
Contributor Author

Please remember including docs for this new option in the docs site. After that, I think this little one is ready to be merged

@mdelapenya Have added the option to the docs.

@mdelapenya mdelapenya self-assigned this Aug 22, 2023
@mdelapenya mdelapenya added the enhancement New feature or request label Aug 22, 2023
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution, much appreciated :)

@mdelapenya mdelapenya merged commit 864dbb3 into testcontainers:main Aug 22, 2023
117 checks passed
@abemedia abemedia deleted the feat/redpanda-tls branch August 22, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants