Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove wrong example from workspace #1556

Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix: remove wrong example from workspace #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d91e04b
fix: remove wrong example from workspace
mdelapenya Aug 30, 2023
d3da2cd
chore: ignore VSCode from CI
mdelapenya Aug 30, 2023
83cd54e
fix: update test
mdelapenya Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@ on:
branches:
- main
paths-ignore:
- '.vscode/**'
- 'mkdocs.yml'
- 'docs/**'
- 'README.md'
pull_request:
paths-ignore:
- '.vscode/**'
- 'mkdocs.yml'
- 'docs/**'
- 'README.md'
Expand Down
4 changes: 0 additions & 4 deletions .vscode/.testcontainers-go.code-workspace
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
"name": "example / pubsub",
"path": "../examples/pubsub"
},
{
"name": "example / questdb",
"path": "../examples/questdb"
},
{
"name": "example / spanner",
"path": "../examples/spanner"
Expand Down
2 changes: 2 additions & 0 deletions modulegen/_template/ci.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@ on:
branches:
- main
paths-ignore:
- '.vscode/**'
- 'mkdocs.yml'
- 'docs/**'
- 'README.md'
pull_request:
paths-ignore:
- '.vscode/**'
- 'mkdocs.yml'
- 'docs/**'
- 'README.md'
Expand Down
4 changes: 2 additions & 2 deletions modulegen/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,11 +459,11 @@ func assertExampleGithubWorkflowContent(t *testing.T, example Example, exampleWo

modulesList, err := ctx.GetModules()
assert.Nil(t, err)
assert.Equal(t, " module: ["+strings.Join(modulesList, ", ")+"]", data[92])
assert.Equal(t, " module: ["+strings.Join(modulesList, ", ")+"]", data[94])

examplesList, err := ctx.GetExamples()
assert.Nil(t, err)
assert.Equal(t, " module: ["+strings.Join(examplesList, ", ")+"]", data[108])
assert.Equal(t, " module: ["+strings.Join(examplesList, ", ")+"]", data[110])
}

// assert content go.mod
Expand Down