chore: remove dependabot groups #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Kudos, SonarCloud Quality Gate passed!
|
mmorel-35
reviewed
Sep 6, 2023
| @@ -9,12 +9,6 @@ type Config struct { | |||
| Updates Updates `yaml:"updates"` | |||
| } | |||
|
|
|||
| type Group struct { | |||
There was a problem hiding this comment.
You can keep groups in the model as it is omitempty. You can just remove it from the constructor
There was a problem hiding this comment.
I was tempted to keep them , but YAGNI made me think about the removal. Do you think we are going to use it at some point?
There was a problem hiding this comment.
@mmorel-35 if you agree, I'm merging this one now
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 6, 2023
* main: chore(deps): bump github.com/tidwall/gjson in /modules/vault (testcontainers#1586) chore(deps): bump github.com/elastic/go-elasticsearch/v8 from 8.0.0 to 8.9.0 in /modules/elasticsearch (testcontainers#1593) chore(deps): bump github.com/aws/aws-sdk-go and aws-sdk-go-v2 in /modules/localstack (testcontainers#1599) chore(deps): bump golang.org/x/text from 0.12.0 to 0.13.0 (testcontainers#1583) chore(deps): bump github.com/docker/docker from 24.0.5+incompatible to 24.0.6+incompatible (testcontainers#1584) chore(deps): bump github.com/google/uuid from 1.3.0 to 1.3.1 (testcontainers#1585) chore: remove dependabot groups (testcontainers#1582) chore(deps): bump actions/checkout from 3 to 4 (testcontainers#1576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the dependabot groups, turning back to a state where each update comes in a single PR
At the same time, skips the GH actions for any PR from @dependabot that is not already approved:
That way, we will be able to manually combine the PRs if/when needed, not exhausting the allocated workers in the GH organisation every time @dependabot sends updates (in a monthly manner).
To extract the above condition, we created this truth table:
Resulting in that we want to process the jobs for the contrary cases of:
Why is it important?
The release notes, that are generated from the PRs, are not clear and it's very difficult for users to understand what's new in terms of dependencies.
Therefore, we are going back to the old, semi-automatic process of combining dependabot PRs using https://github.com/mdelapenya/gh-combine-prs
Related issues