Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redpanda): add wait for listening port condition on startup #1828

Merged

Conversation

sbuliarca
Copy link
Contributor

What does this PR do?

When starting the Redpanda container, adds the readiness condition to wait for the listening port to be available.

Why is it important?

The container may not be ready to accept connections yet, although the process started gets to log the targetted log: "Successfully started Redpanda!"

Related issues

How to test this PR

Just run the tests in the redpanda module:

cd modules/redpanda
make test

@sbuliarca sbuliarca requested a review from a team as a code owner October 27, 2023 11:39
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 350cc13
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/653ba1884e4fbb0008476e27
😎 Deploy Preview https://deploy-preview-1828--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Oct 27, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 27, 2023
@mdelapenya mdelapenya merged commit aad7074 into testcontainers:main Oct 27, 2023
111 checks passed
@sbuliarca sbuliarca deleted the redpanda-container-readiness-fix branch October 30, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: redpanda testcontainer not fully ready to accept connections
2 participants