fix: fallback matching of registry authentication config #1927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will fix an issue when config.json contains
auths
with keys set to the a registry URL such ashttps://artifactory.com
. This way the authentication configuration for the registry will be matched with the configuration file and used.Why is it important?
In case where a registry is configured with an
https://
prefix, the authentication to pull images from that registry fails.How to test this PR
Manually add a registry and its authentication config in the
~/.docker/config.json
and run a test that requires authentication to pull images and start containers.