feat: exec multiplexed to return stderr #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # docker_exec_test.go
mdelapenya
reviewed
Dec 1, 2023
| @@ -129,7 +129,7 @@ require ( | |||
| github.com/secure-systems-lab/go-securesystemslib v0.4.0 // indirect | |||
| github.com/serialx/hashring v0.0.0-20190422032157-8b2912629002 // indirect | |||
| github.com/shibumi/go-pathspec v1.3.0 // indirect | |||
| github.com/shirou/gopsutil/v3 v3.23.9 // indirect | |||
| github.com/shirou/gopsutil/v3 v3.23.10 // indirect | |||
There was a problem hiding this comment.
This change is probably unrelated, but let's include it as it's harmless
mdelapenya
approved these changes
Dec 1, 2023
mdelapenya
added
feature
|
I'm changing the |
mdelapenya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows container command execution to return stderr, when the command execution produces an error.
Why is it important?
It's important to get the output of a error when executing a command in a container, to facilitate the error debug.
Related issues