-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Recreate Ryuk container if terminated #2084
fix: Recreate Ryuk container if terminated #2084
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, once resolved, I think we are good to go, Thanks!
964b47b
to
605ca7b
Compare
605ca7b
to
d50621c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Great. Could you run the test suite one more time for me? I had to update the branch. Thanks! |
What does this PR do?
Fixes ryuk recreation such that a new container is spun up if the previous container has terminated and been removed. This involves checking for ErrNotFound during the Ryuk state check, triggering the creation of a new ryuk container if this error is returned.
It is essential to reset
reaperOnce
. Without resetting, no attempt to create a new reaper will be made.Why is it important?
Related issues
How to test this PR
Run test
Test_RecreateReaperIfTerminated
to validate changes.Or run the following test suite with env variable
SLEEP=11s
. Without changes made in this PRTestC
would fail, but with them all tests pass.