Go install gotestsum and golangci-lint #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmorel-35
changed the title
|
Hi @mdelapenya , |
mdelapenya
approved these changes
Jan 18, 2024
From Make docs: https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
So I think it's fine to keep those two without PHONY, as they are indeed files. Thanks for raising the concern 🙇 |
mdelapenya
added a commit
to jespino/testcontainers-go
that referenced
this pull request
Jan 18, 2024
* main: enable golangci-lint for redis module (testcontainers#2126) Go install gotestsum and golangci-lint (testcontainers#2127) improve OSSF score (testcontainers#2125) chore: run make lint on new modules (testcontainers#2122) enable golangci-lint for pulsar (testcontainers#2121) lint: enable testifylint (testcontainers#2120) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (testcontainers#2094) chore(deps): bump golang.org/x/sys from 0.15.0 to 0.16.0 (testcontainers#2104) Revert "chore(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0 (testcontainers#2088)"
mdelapenya
added a commit
that referenced
this pull request
Jan 20, 2024
….com/docker/compose/v2-2.24.0 * main: pin Docker images version (#2129) enable golangci-lint for examples (#2128) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (#2098) enable golangci-lint for redis module (#2126) Go install gotestsum and golangci-lint (#2127) improve OSSF score (#2125)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jan 24, 2024
* main: (25 commits) chore(deps): bump github.com/dvsekhvalnov/jose2go in /modules/pulsar (testcontainers#2136) fix: skip-host-cache option removed in latest MySQL 8.3.0 version (testcontainers#2130) chore: skip assertions for Docker Rootless (testcontainers#2135) pin Docker images version (testcontainers#2129) enable golangci-lint for examples (testcontainers#2128) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#2098) enable golangci-lint for redis module (testcontainers#2126) Go install gotestsum and golangci-lint (testcontainers#2127) improve OSSF score (testcontainers#2125) chore: run make lint on new modules (testcontainers#2122) enable golangci-lint for pulsar (testcontainers#2121) lint: enable testifylint (testcontainers#2120) chore(deps): bump github.com/nats-io/nats.go in /modules/nats (testcontainers#2094) chore(deps): bump golang.org/x/sys from 0.15.0 to 0.16.0 (testcontainers#2104) Revert "chore(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0 (testcontainers#2088)" chore(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0 (testcontainers#2088) chore(deps): bump cloud.google.com/go/spanner from 1.54.0 to 1.55.0, google.golang.org/api from 0.154.0 to 0.156.0 in /modules/gcloud (testcontainers#2115) chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.25.10 to 1.26.3, github.com/aws/aws-sdk-go from 1.48.13 to 1.49.19 in /modules/localstack (testcontainers#2114) chore(deps): bump github.com/docker/go-connections from 0.4.0 to 0.5.0 (testcontainers#2113) Adding mockserver module (testcontainers#2085) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Define Makefile targets to install golangci-lint and gotestsum
Why is it important?
Helps having the right requirements to make different targets work.