Move the container and config tests into a test package #2242
Conversation
This work has been extracted from testcontainers#2202 and is related to testcontainers#2180. See the original PR for the full context and reasoning.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
utils_test.go
Outdated
| @@ -0,0 +1,36 @@ | |||
| package testcontainers_test | |||
There was a problem hiding this comment.
Is there a reason for this file to be here? I cannot see usages of the functions on it in the current changeset
There was a problem hiding this comment.
These are utilities that are currently in the docker_test file and are used in the modified tests. Since the docker_test file isn't moved yet, I've temporarily created this utils file, it should go away when every thing is migrated 🙂
There was a problem hiding this comment.
The terminateContainerOnEnd is used in most of the test files that were moved into their own packages, so we do need to move them to a into the testcontainers_test package so they're accessible. They don't show up in the diff because I didn't touch those lines, I only moved the tests.
…st-to-test-package
…st-to-test-package
* main: (239 commits) Move the container and config tests into a test package (testcontainers#2242) Added error handling for context.Canceled in log reading code (testcontainers#2268) chore: updated docker compose version (testcontainers#2340) Add method for getting Weaviate's gRPC port (testcontainers#2339) chore: use withEnv in localstack module (testcontainers#2337) docs: fix wrong copy&paste (testcontainers#2338) fix: consul race on HTTP port (testcontainers#2336) chore(deps): bump mkdocs-material from 8.2.7 to 9.5.13 (testcontainers#2334) feat: add openfga module (testcontainers#2332) chore: retire dependabot (testcontainers#2325) chore: check that the new version is not empty (testcontainers#2331) chore: prepare for next minor development cycle (0.30.0) chore: use new version (v0.29.1) in modules and examples fix: incorrect version chore: prepare for next minor development cycle () chore: use new version (v0.29.0) in modules and examples generic.go: GenericContainer(): clearer error message (testcontainers#2327) chore: confirm support for new mongo images (testcontainers#2326) Add k3s WithManifest option (testcontainers#1920) chore(deps): bump google.golang.org/grpc in /modules/qdrant (testcontainers#2281) ...
What does this PR do?
This work has been extracted from #2202 and is related to #2180. See the original PR for the full context and reasoning.
Why is it important?
This will help with the documentation, since all examples will now have the module prefixes.
Related issues