feat(exitcode): Add exit code sugar method #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Mar 12, 2024
mdelapenya
reviewed
Mar 12, 2024
mdelapenya
reviewed
Mar 18, 2024
wait/exec_test.go
Outdated
| @@ -156,6 +156,27 @@ func TestExecStrategyWaitUntilReady_CustomExitCode(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestExecStrategyWaitUntilReadyWithSugaryExitCode(t *testing.T) { | |||
There was a problem hiding this comment.
Not a blocker, but more consistent name with other test functions
Suggested change
| func TestExecStrategyWaitUntilReadyWithSugaryExitCode(t *testing.T) { | |
| func TestExecStrategyWaitUntilReady_ExitCode(t *testing.T) { |
There was a problem hiding this comment.
@mdelapenya Updated.
|
Merged in main |
mdelapenya
reviewed
Mar 25, 2024
mdelapenya
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Hi @bearrito I think once we change the test method, this is ready to be merged.
Thanks for your time contributing to the library!
|
@mdelapenya Updated. |
mdelapenya
added
the
feature
mdelapenya
approved these changes
Mar 27, 2024
mdelapenya
added a commit
to coffeegoddd/testcontainers-go
that referenced
this pull request
Apr 12, 2024
* main: (115 commits) chore: create TLS certs in a consistent manner (testcontainers#2478) chore(deps): bump idna from 3.6 to 3.7 (testcontainers#2480) Elasticsearch disable CA retrieval when ssl is disabled (testcontainers#2475) fix: handle dockerignore exclusions properly (testcontainers#2476) chore: prepare for next minor development cycle (0.31.0) chore: use new version (v0.30.0) in modules and examples Fix url creation to handle query params when using HTTP wait strategy (testcontainers#2466) fix: data race on container run (testcontainers#2345) fix: logging deadlock (testcontainers#2346) feat(k6):Add remote test scripts (testcontainers#2350) feat: optimizes file copies to and from containers (testcontainers#2450) fix(exec): updates the `Multiplexed` opt to combine stdout and stderr (testcontainers#2452) Upgrade neo4j module to use features from v0.29.1 of testcontainers-go (testcontainers#2463) bug:Fix AMQPS url (testcontainers#2462) chore: more compose updates in comments chore: use "docker compose" (v2) instead of "docker-compose" (v1) (testcontainers#2464) chore(deps): bump github/codeql-action from 2.22.12 to 3.24.9 (testcontainers#2459) refactor: Add Weaviate modules tests (testcontainers#2447) feat(exitcode): Add exit code sugar method (testcontainers#2342) feat: add module to support InfluxDB v1.x (testcontainers#1703) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add syntax sugar on exit code handling.
Why is it important?
I don't know. I was just looking at
good first issuetags#2205
How to test this PR
Run the added unit tests.