feat: authenticate docker on PullImage #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using k3s and specifically its LoadImages function to avoid hassle for images not published to a public repository. Through this, I noticed we were accidentally only authenticating docker pulls when launching a container. This authenticates the same way, regardless of if you are launching a container or pulling its image. This also improves the LoadImages test as before, the pod could have not started due to an image problem, yet still pass the test. Signed-off-by: Adrian Cole <adrian@tetrate.io>
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
mdelapenya
approved these changes
Mar 25, 2024
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 26, 2024
* main: feat: add module to support InfluxDB v1.x (testcontainers#1703) feat: authenticate docker on PullImage (testcontainers#2446) feat: add distribution-registry module (testcontainers#2341) chore(deps): Bumping ChromaGo client version (testcontainers#2402) chore(deps): bump github.com/docker/docker from 25.0.3+incompatible to 25.0.5+incompatible (testcontainers#2444) feat: support passing io.Reader as ContainerFile (testcontainers#2401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This authenticates on PullImage and improves the k3s LoadImages test so that a failure to start the pod will fail the test.
Why is it important?
I'm using k3s with private images, so I want to use the
LoadImagesfeature. The instructions to do this included runningPullImagefirst, which works on anonymous images, but not authenticated ones. By re-using the same auth code used to run a container, I can now use theLoadImagesfeature in k3s with private images.While trying to figure out what was wrong I used
Test_LoadImageswhich is quite nice, but accidentally had a problem where a container can fail to run, yet still pass the test. This lost me time, so I figured I would improve it for the next person.Related issues
maybe #1685?
How to test this PR
Change the image in Test_LoadImages from "nginx" to a privately hosted image (like a private github repository). Before, it would fail to pull, and now it won't.