-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vearch module #2560
feat: add vearch module #2560
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @zhanghexian thanks for creating this new module. Could you share more context about this technology please? Also, regarding new module contributions, I recommend you reading https://golang.testcontainers.org/modules/, as it comes with instructions on how to run the module generator tool, which adds the module to multiple files for you: GH actions, mkdocs, sonar, etc |
Hi, I actually want to submit the vearch vector database to langchaingo, but combined with the existed pr, I need to submit now in the testcontainers-go project to build the vearch test dependency (vearch is not accepted in langchaingo, so the self-calling vearch cannot get, so the Vearch is not accepted. Can't pass the test), please give me some advice, thank you! |
@zhanghexian could you fill in the PR template 🙏 ? |
i am sorry,could you tell me how can i fill the PR template? and where? |
It has been modified, is there anything else that needs to be modified, thank you! |
@zhanghexian could you please run the generator? The makefile is missing too |
i am sorry,i forget upload Makefile,sorry! |
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
@zhanghexian I downloaded this PR and the module does not even start. Could you please verify it locally? I had to go to vearch docs to understand how to run the project, reading their compose file: they have a TOML config file, and they need //go:embed config/config.toml
var configFile string
func RunContainer(...) {
req := testcontainers.ContainerRequest{
Image: "vearch/vearch:3.5.1",
ExposedPorts: []string{"8817/tcp", "9001/tcp"},
Cmd: []string{"all"},
Files: []testcontainers.ContainerFile{
{
Reader: strings.NewReader(configFile),
ContainerFilePath: "/vearch/config/config.toml",
},
},
WaitingFor: wait.ForAll(
wait.ForListeningPort("8817/tcp"),
wait.ForListeningPort("9001/tcp"),
).WithDeadline(time.Minute * 1),
} and it does not even start in that time. I'm marking this PR as draft until you get it passing locally. Besides that, make sure you run Finally, I'd suggest adding a testable example showcasing how to consume this module using the Go SDK for vearch, which will be very helpful for the users of the module. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
thanks for your help! |
* main: feat: add vearch module (#2560)
* main: (48 commits) Fix race condition when looking up reaper (ryuk) container (testcontainers#2508) chore: bring golangci-lint back (testcontainers#2571) docs(compose): Fix typo docker compose docs (testcontainers#2565) Handle error properly during port forwarding initialization. (testcontainers#2550) chore: pin vearch version (testcontainers#2568) feat: add vearch module (testcontainers#2560) chore: run tests against latest Docker engine, nightly (testcontainers#2566) chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.0.7 (testcontainers#2562) Fix network accessor for port-forwarding feature (testcontainers#2551) --- (testcontainers#2549) fix: update search bar eval in mkdocs (testcontainers#2547) docs: improve contributing docs for code snippets (testcontainers#2546) chore: use a virtualenv for working with the docs site (testcontainers#2545) docs: document test session semantics (testcontainers#2544) feat(ryuk): allow to configure ryuk timeouts using env variables (testcontainers#2541) docs: fix CircleCI docs (testcontainers#2539) fix: add import to module generation (testcontainers#2537) chore: prepare for next minor development cycle (0.32.0) chore: use new version (v0.31.0) in modules and examples feat(mongodb): add replica set support via opts (testcontainers#2469) ...
What does this PR do?
add vearch modules to generate dependence!
Why is it important?
To add vearch in langchaingo