chore: improve log handling when container is stopping #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
reviewed
Jun 24, 2024
|
@ash2k do you think it's possible to write a test replicating the scenario where the container is stopped and the error is not present anymore? |
|
I'm not sure how to test this. Start a container, emit logs, check that there is no error written to stderr? Seems too complicated just to test if a log line is written. Are there any similar tests? |
|
@mdelapenya Friendly ping. I'd like to get this merged as I'd like to send a few more PRs and ideally don't want to have more than one in flight. |
mdelapenya
changed the title
mdelapenya
added a commit
that referenced
this pull request
Jun 28, 2024
mdelapenya
added a commit
to thaJeztah/testcontainers-go
that referenced
this pull request
Jun 28, 2024
* main: chore: test cleanups (testcontainers#2608) chore(ci): pass docker install type to the nightly build payload (testcontainers#2612) chore: run rootless mode in nighlty builds (testcontainers#2611) chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605) chore: improve log handling when container is stopping (testcontainers#2601)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jul 2, 2024
* main: chore(deps): bump github.com/docker/docker from v26.1.4 to v27.0.2 (testcontainers#2593) fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE (testcontainers#2536) chore: test cleanups (testcontainers#2608) chore(ci): pass docker install type to the nightly build payload (testcontainers#2612) chore: run rootless mode in nighlty builds (testcontainers#2611) chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605) chore: improve log handling when container is stopping (testcontainers#2601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm getting an error when my container cleanly stops:
Please see individual commits. I tried to tidy up a bit, I hope this is fine.
Why is it important?
The error is a red herring and distracts users of the library.
Related issues