Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: container.Endpoint and wait.FortHTTP to use lowest internal port #2641

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: container.Endpoint and wait.FortHTTP to use lowest internal port #2641

merged 1 commit into from
Jul 18, 2024

Commits on Jul 17, 2024

  1. fix: container.Endpoint and wait.FortHTTP to use lowest internal port 

    Ensure Container.Endpoint returns the lowest numbered aka first port
there is more than one exposed.

Ensure that wait.ForHTTP uses the lowest numbered aka first port
when there is more than one exposed.

Prior to this a random port would be returned leading to unpredictable
results.

Clarify which port is uses by using lowest vs first, which could
otherwise be interpreted as the first one specified.

Fixed: testcontainers#2640
    @stevenh
    stevenh committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d0b3354 View commit details
    Browse the repository at this point in the history