Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix compilation of examples #2656

Merged

Conversation

alexandear
Copy link
Contributor

What does this PR do?

Fixes the compilation of the code snippet examples "Reusable Container" and "Spin Up Redis".

Why is it important?

Users reading the documentation should be able to copy and paste the code snippets, and they should work without any modifications.

@alexandear alexandear requested a review from a team as a code owner July 17, 2024 10:43
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 6c58647
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6697a057ccd71f0008ac8104
😎 Deploy Preview https://deploy-preview-2656--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The docs are super important to us, and it's clear we missed the updates for those one. So thank you for this.

LGTM!

@mdelapenya mdelapenya self-assigned this Jul 17, 2024
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Jul 17, 2024
@mdelapenya mdelapenya merged commit 016de01 into testcontainers:main Jul 17, 2024
7 checks passed
@alexandear alexandear deleted the docs/fix-examples-compilation branch July 17, 2024 11:02
mdelapenya added a commit that referenced this pull request Aug 5, 2024
* main:
  feat: add grafana-lgtm module (#2660)
  Added valkey module (#2639)
  fix: container.Endpoint and wait.FortHTTP to use lowest internal port (#2641)
  chore: test cleanups (#2657)
  docs: fix compilation of examples (#2656)
  feat: add custom container registry substitutor (#2647)
  fix: couchbase containers intermittently hang on startup (#2650)
  chore(deps): bump Ryuk to 0.8.1 (#2648)
  fix: retry on label error (#2644)
  perf: optimise docker authentication config lookup (#2646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants