Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter context errors from log production #2715

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: filter context errors from log production #2715

merged 1 commit into from
Aug 9, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Aug 8, 2024

Don't return context errors from log production as it's confusing to callers which cancel, making it harder to understand any actual errors that occurred.

@stevenh
fix: filter context errors from log production
533f4fc 
Don't return context errors from log production as it's confusing to
callers which cancel, making it harder to understand any actual errors
that occurred.
@stevenh stevenh requested a review from a team as a code owner August 8, 2024 18:45
@netlify Netlify
Copy link

netlify bot commented Aug 8, 2024 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 533f4fc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66b5123b39bbbf00082c4e7f
😎 Deploy Preview https://deploy-preview-2715--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenh stevenh mentioned this pull request Aug 8, 2024
Closed
mdelapenya
mdelapenya approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelapenya mdelapenya self-assigned this Aug 9, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 9, 2024
@mdelapenya mdelapenya merged commit 3c326f8 into testcontainers:main Aug 9, 2024
112 checks passed
mdelapenya added a commit that referenced this pull request Aug 12, 2024
@mdelapenya
Merge branch 'main' into v1
372e67f 
* main:
  fix: readiness hook back off (#2718)
  fix: skip unhealthy (#2717)
  fix: filter context errors from log production (#2715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenh @mdelapenya