Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redpanda): wait for #2794

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(redpanda): wait for #2794

merged 1 commit into from
Sep 27, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Sep 21, 2024

Wait for the admin interface to response to HTTP to avoid failures in configuring the instance when its not fully ready.

Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 4b9bc36
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66f58b9819766b0008f2c63e
😎 Deploy Preview https://deploy-preview-2794--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenh stevenh marked this pull request as ready for review September 21, 2024 13:40
@stevenh stevenh requested a review from a team as a code owner September 21, 2024 13:40
mdelapenya
mdelapenya previously approved these changes Sep 26, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Wait for the admin interface to response to HTTP to avoid failures in
configuring the instance when its not fully ready.

Clean up error wrapping.
@mdelapenya mdelapenya self-assigned this Sep 27, 2024
@mdelapenya mdelapenya added the bug An issue with the library label Sep 27, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 9562594 into main Sep 27, 2024
114 checks passed
@mdelapenya mdelapenya deleted the fix/redpanda-wait branch September 27, 2024 07:41
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 27, 2024
* main:
  fix(redpanda): wait for (testcontainers#2794)
  fix(elasticsearch): wait for (testcontainers#2724)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 30, 2024
* main:
  feat: add dynamodb-local module (testcontainers#2799)
  fix(redpanda): wait for (testcontainers#2794)
mdelapenya added a commit that referenced this pull request Oct 17, 2024
* main:
  chore: replace 'assert' with 'require' (#2827)
  chore: replace 'assert' with 'require' for critical checks (#2824)
  chore: bump ryuk to latest release (#2818)
  feat: add require for critical checks (#2812)
  chore(deps): bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (#2805)
  feat: add etcd module (#2788)
  feat: add dynamodb-local module (#2799)
  fix(redpanda): wait for (#2794)
  fix(elasticsearch): wait for (#2724)
  chore: update dockercfg module (#2801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants