fix(grafana): update module path #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Sep 25, 2024
| @@ -1,4 +1,4 @@ | |||
| module github.com/testcontainers/testcontainers-go/modules/grafanalgtm | |||
| module github.com/testcontainers/testcontainers-go/modules/grafana-lgtm | |||
There was a problem hiding this comment.
I need to verify the implications on changing the module name of an already published module (appeared in v0.33.0)
There was a problem hiding this comment.
never ideal but its is pre v1.0 so this is the time to do it and guessing it wasn't working?
stevenh
approved these changes
Sep 25, 2024
| @@ -1,4 +1,4 @@ | |||
| module github.com/testcontainers/testcontainers-go/modules/grafanalgtm | |||
| module github.com/testcontainers/testcontainers-go/modules/grafana-lgtm | |||
There was a problem hiding this comment.
never ideal but its is pre v1.0 so this is the time to do it and guessing it wasn't working?
mdelapenya
added a commit
that referenced
this pull request
Sep 26, 2024
* main: (29 commits) fix: template for code generation (#2800) fix: update module path (#2797) fix: container logging deadlocks (#2791) chore: use a much smaller image for testing (#2795) fix: parallel containers clean race (#2790) fix(registry): wait for (#2793) fix: container timeout test (#2792) docs: document redpanda options (#2789) feat: support databend module (#2779) chore: golangci-lint 1.61.0 (#2787) fix(mssql): bump Docker image version (#2786) fix: handle 127 error code for podman compatibility (#2778) fix: do not override ImageBuildOptions.Labels when building from a Dockerfile (#2775) feat(mongodb): Wait for mongodb module with a replicaset to finish (#2777) fix(postgres): Apply default snapshot name if no name specified (#2783) fix: resource clean up for tests and examples (#2738) ci: add generate for mocks (#2774) fix: docker config error handling when config file does not exist (#2772) docs: refine heading badges in README (#2770) feat(wait): for file (#2731) ...
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 26, 2024
* main: chore: update dockercfg module (testcontainers#2801) fix: template for code generation (testcontainers#2800) fix: update module path (testcontainers#2797) fix: container logging deadlocks (testcontainers#2791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It updates the module path from
grafanalgtmtografana-lgtm.Why is it important?
During the release process of the modules, the git tag for each module uses the directory name as tag name, so it was wrong for grafana: its directory is
grafana-lgtmand the module usedgrafanalgtm.As a consequence, the pkg.go.dev site did not recognize the Grafana module.
Related issues