Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use require.(No)Error(t,err) instead of t.Fatal(err) #2851

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore: use require.(No)Error(t,err) instead of t.Fatal(err) #2851

merged 1 commit into from
Oct 28, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 26, 2024 •
edited by mdelapenya
Loading

What does this PR do?

This uses require.(No)Error(t,err) instead of t.Fatal(err) calls

Why is it important?

This reduce the number of lines required to make an assertion.
It also make the assertion easier to understand.

Related issues

@mmorel-35
chore: use require.(No)Error(t,err) instead of t.Fatal(err)
600a556 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 requested a review from a team as a code owner October 26, 2024 12:01
@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 600a556
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/671cda23cb1d530008e5ffae
😎 Deploy Preview https://deploy-preview-2851--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdelapenya
mdelapenya approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Oct 28, 2024
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality hacktoberfest Pull Requests accepted for Hacktoberfest. labels Oct 28, 2024
@mdelapenya mdelapenya merged commit b7511cd into testcontainers:main Oct 28, 2024
122 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Oct 28, 2024
@mdelapenya
Merge branch 'main' into context-support
5511d17 
* main:
  chore: use require.(No)Error(t,err) instead of t.Fatal(err) (testcontainers#2851)
  fix: simplify fully-qualified image names (testcontainers#2846)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Oct 28, 2024
@mdelapenya
Merge branch 'main' into go-workfile
0463cc6 
* main:
  chore: use require.(No)Error(t,err) instead of t.Fatal(err) (testcontainers#2851)
mdelapenya added a commit that referenced this pull request Oct 28, 2024
@mdelapenya
Merge branch 'main' into fix/compose-containers
d5a1383 
* main:
  fix!: data races (#2843)
  fix: mongodb replicaset should work with auth (#2847)
  chore: use require.(No)Error(t,err) instead of t.Fatal(err) (#2851)
  fix: simplify fully-qualified image names (#2846)
@mmorel-35 mmorel-35 deleted the testifier/require-error branch October 28, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
chore Changes that do not impact the existing functionality hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @mdelapenya