Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use require instead of t.Fatal #2855

Merged
merged 3 commits into from
Oct 29, 2024
Merged

chore: use require instead of t.Fatal #2855

merged 3 commits into from
Oct 29, 2024

Conversation

mmorel-35
Copy link
Contributor

What does this PR do?

This uses require instead of t.Fatal calls

Why is it important?

This reduce the number of lines required to make an assertion.
It also make the assertion easier to understand.

Related issues

@mmorel-35 mmorel-35 requested a review from a team as a code owner October 29, 2024 07:05
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit aeeb7ab
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6720ab29558e590008e92fdd
😎 Deploy Preview https://deploy-preview-2855--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmorel-35 mmorel-35 force-pushed the testifier/require-error branch from 44d6717 to be2a5d8 Compare October 29, 2024 07:10
@mmorel-35
chore: use require instead of t.Fatal
8424fb2 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the testifier/require-error branch from be2a5d8 to 8424fb2 Compare October 29, 2024 09:15
mdelapenya
mdelapenya reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, regarding the usage of require.Zero, other than that, LGTM

docker_test.go Outdated Show resolved Hide resolved
docker_test.go Outdated Show resolved Hide resolved
docker_test.go Outdated Show resolved Hide resolved
docker_test.go Outdated Show resolved Hide resolved
docker_test.go Outdated Show resolved Hide resolved
image_test.go Outdated Show resolved Hide resolved
modules/kafka/kafka_helpers_test.go Outdated Show resolved Hide resolved
modules/rabbitmq/rabbitmq_test.go Show resolved Hide resolved
modules/neo4j/neo4j_test.go Outdated Show resolved Hide resolved
port_forwarding_test.go Outdated Show resolved Hide resolved
mmorel-35 and others added 2 commits October 29, 2024 10:25
@mmorel-35 @mdelapenya
Apply suggestions from code review
ba74bbb 
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
@mmorel-35
Update kafka_helpers_test.go
aeeb7ab
@mdelapenya mdelapenya self-assigned this Oct 29, 2024
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality hacktoberfest Pull Requests accepted for Hacktoberfest. labels Oct 29, 2024
mdelapenya
mdelapenya approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 09a5482 into testcontainers:main Oct 29, 2024
122 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Oct 29, 2024
@mdelapenya
Merge branch 'main' into go-workfile
cbfdea7 
* main:
  chore: use require instead of t.Fatal (testcontainers#2855)
@mmorel-35 mmorel-35 deleted the testifier/require-error branch October 29, 2024 10:54
@mmorel-35 mmorel-35 mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
chore Changes that do not impact the existing functionality hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @mdelapenya