Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable implicit default logger only in testing with -v #2877

Merged
merged 3 commits into from
Dec 5, 2024
Merged

chore: enable implicit default logger only in testing with -v #2877

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd0088b
Enable default logger only in testing
apstndb Nov 6, 2024
a9fbef9
Fix default logger assigning
apstndb Nov 6, 2024
629a514
Merge branch 'main' into fix/respect-testing
mdelapenya Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,18 @@ import (
)

// Logger is the default log instance
var Logger Logging = log.New(os.Stderr, "", log.LstdFlags)
var Logger Logging = &noopLogger{}

func init() {
for _, arg := range os.Args {
if strings.EqualFold(arg, "-test.v=true") || strings.EqualFold(arg, "-v") {
return
// Enable default logger in the testing with a verbose flag.
if testing.Testing() {
// Parse manually because testing.Verbose() panics unless flag.Parse() has done.
for _, arg := range os.Args {
if strings.EqualFold(arg, "-test.v=true") || strings.EqualFold(arg, "-v") {
Logger = log.New(os.Stderr, "", log.LstdFlags)
}
}
}

// If we are not running in verbose mode, we configure a noop logger by default.
Logger = &noopLogger{}
}

// Validate our types implement the required interfaces.
Expand Down