Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Enable master moby with rootless #2880

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(ci): Enable master moby with rootless #2880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions .github/workflows/docker-moby-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ jobs:
matrix:
rootless-docker: [true, false]
containerd-integration: [true, false]
# ghaction-setup-docker doesn't work with rootless yet
exclude:
- rootless-docker: true
containerd-integration: true

name: "Core tests using latest moby/moby"
runs-on: 'ubuntu-latest'
Expand All @@ -25,14 +21,6 @@ jobs:
echo "docker_install_type=${{ matrix.rootless-docker == true && 'Rootless' || 'Rootful' }}" >> "$GITHUB_ENV"
echo "containerd_integration=${{ matrix.containerd-integration == true && 'containerd' || '' }}" >> "$GITHUB_ENV"

- name: Setup rootless Docker
if: ${{ matrix.rootless-docker }}
uses: ScribeMD/rootless-docker@6bd157a512c2fafa4e0243a8aa87d964eb890886 # v0.2.2

- name: Remove Docker root socket
if: ${{ matrix.rootless-docker }}
run: sudo rm -rf /var/run/docker.sock

- name: Check out code into the Go module directory
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4

Expand All @@ -50,22 +38,17 @@ jobs:
run: go mod tidy

- name: Install Nightly Docker
# rootless not supported with ghaction-setup-docker yet
if: ${{ matrix.rootless-docker == false }}
uses: crazy-max/ghaction-setup-docker@master
with:
rootless: ${{ matrix.rootless-docker }}
version: type=image,tag=master
daemon-config: |
{
"debug": true,
"features": {
"containerd-snapshotter": ${{ matrix.containerd-integration }}
}
}
version: type=image,tag=master

- name: Install test Docker
if: ${{ matrix.rootless-docker }}
run: curl https://get.docker.com | CHANNEL=test sh

- name: go test
timeout-minutes: 30
Expand Down